MDEV-39928 Fix GitLab CI centos9 job failure#5198
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
gkodinov
left a comment
There was a problem hiding this comment.
Thank you for your contribution! This is a preliminary review.
I have tried looking into when CentOS9 lost its mariadb server package, but couldn't find anything.
Nevertheless, this sounds like a bug fix to me, so I'd like to request that you rebase this towards 11.8 (this seems to be the earliest release train that has centos 9).
FWIW, 10.11 has CentOS7, but I'm not sure if that one is affected.
gkodinov
left a comment
There was a problem hiding this comment.
LGTM. Please stay tuned for the final review.
|
Note our CI dependency list is https://github.com/MariaDB/buildbot/blob/dev/ci_build_images/centos.Dockerfile. eigen3-devel should be removed (decided not to use it for vector). Some I can't explain (subversion). |
The centos9 job uses yum-builddep -y mariadb-server to install build dependencies, but the mariadb-server source package has been removed from CentOS Stream 9 repositories. Replace with explicit installation of the required build dependencies. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.
Description
The centos9 job in
.gitlab-ci.ymlfails because it usesyum-builddep -y mariadb-serverto install build dependencies, but themariadb-serversource package has been removed from CentOS Stream 9 repositories. This affects all branches that define the centos9 job (main,10.11,11.4,11.8,12.3).Fix:
yum-builddep -y mariadb-serverwith explicit build dependency installationliburing-develfor io_uring supportRelease Notes
N/A
How can this PR be tested?
Run GitLab CI on this branch and verify the centos9 job passes. The build should complete successfully.
Before this change:
After this change:
Basing the PR against the correct MariaDB version
Copyright
All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.